fix: 5217 - no check on cookie as it's always null (#5222)

openfoodfacts · May 6, 2024 · d744fab · d744fab
1 parent 2594b38
commit d744fab
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/packages/smooth_app/lib/data_models/user_management_provider.dart b/packages/smooth_app/lib/data_models/user_management_provider.dart
@@ -45,7 +45,7 @@ class UserManagementProvider with ChangeNotifier {
     try {
       effectiveUserId = userId ?? await DaoSecuredString.get(_USER_ID);
       effectivePassword = password ?? await DaoSecuredString.get(_PASSWORD);
-      effectiveCookie = password ?? await DaoSecuredString.get(_COOKIE);
+      effectiveCookie = await DaoSecuredString.get(_COOKIE);
     } on PlatformException {
       /// Decrypting the values can go wrong if, for example, the app was
       /// manually overwritten from an external apk.
@@ -55,9 +55,7 @@ class UserManagementProvider with ChangeNotifier {
       Logs.e('Credentials query failed, you have been logged out');
     }
 
-    if (effectiveUserId == null ||
-        effectivePassword == null ||
-        effectiveCookie == null) {
+    if (effectiveUserId == null || effectivePassword == null) {
       return;
     }