fix: #3536 don't force entry into edit screen on card tap (#3540)

* don't force entry into edit screen on card tap * remove unused import
openfoodfacts · Jan 6, 2023 · f39de2a · f39de2a
1 parent 1190474
commit f39de2a
Showing 1 changed file with 24 additions and 40 deletions.
diff --git a/packages/smooth_app/lib/cards/product_cards/product_title_card.dart b/packages/smooth_app/lib/cards/product_cards/product_title_card.dart
@@ -5,7 +5,6 @@ import 'package:provider/provider.dart';
 import 'package:smooth_app/generic_lib/design_constants.dart';
 import 'package:smooth_app/helpers/extension_on_text_helper.dart';
 import 'package:smooth_app/helpers/product_cards_helper.dart';
-import 'package:smooth_app/pages/product/add_basic_details_page.dart';
 
 class ProductTitleCard extends StatelessWidget {
   const ProductTitleCard(
@@ -28,50 +27,35 @@ class ProductTitleCard extends StatelessWidget {
       value: product,
       child: Align(
         alignment: AlignmentDirectional.topStart,
-        child: InkWell(
-          onTap: _hasProductName
-              ? () async {
-                  await Navigator.push<Product?>(
-                    context,
-                    MaterialPageRoute<Product>(
-                      builder: (BuildContext context) =>
-                          AddBasicDetailsPage(product),
-                    ),
-                  );
-                }
-              : null,
-          child: Column(
-            crossAxisAlignment: CrossAxisAlignment.start,
-            children: <Widget>[
-              Row(
-                crossAxisAlignment: CrossAxisAlignment.start,
-                children: <Widget>[
-                  Expanded(
-                    child: _ProductTitleCardName(
-                      selectable: isSelectable,
-                    ),
+        child: Column(
+          crossAxisAlignment: CrossAxisAlignment.start,
+          children: <Widget>[
+            Row(
+              crossAxisAlignment: CrossAxisAlignment.start,
+              children: <Widget>[
+                Expanded(
+                  child: _ProductTitleCardName(
+                    selectable: isSelectable,
                   ),
-                  Expanded(
-                    child: _ProductTitleCardTrailing(
-                      removable: isRemovable,
-                      selectable: isSelectable,
-                      onRemove: onRemove,
-                    ),
-                  )
-                ],
-              ),
-              _ProductTitleCardBrand(
-                removable: isRemovable,
-                selectable: isSelectable,
-              ),
-            ],
-          ),
+                ),
+                Expanded(
+                  child: _ProductTitleCardTrailing(
+                    removable: isRemovable,
+                    selectable: isSelectable,
+                    onRemove: onRemove,
+                  ),
+                )
+              ],
+            ),
+            _ProductTitleCardBrand(
+              removable: isRemovable,
+              selectable: isSelectable,
+            ),
+          ],
         ),
       ),
     );
   }
-
-  bool get _hasProductName => product.productName != null;
 }
 
 class _ProductTitleCardName extends StatelessWidget {