Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a hero animation to the product summary card #1114

Closed
Tracked by #1416
, #1171
...
M123-dev opened this issue Feb 11, 2022 · 2 comments · Fixed by #1334
Closed
Tracked by #1416
, #1171
...

Add a hero animation to the product summary card #1114

M123-dev opened this issue Feb 11, 2022 · 2 comments · Fixed by #1334
Labels
animations summary card

Comments

@M123-dev
Copy link
Member

M123-dev commented Feb 11, 2022 •
edited by teolemon
Loading

What

  • Why not provide a small hero animation for the summery card

Part of
@teolemon teolemon changed the title Product summery card hero animation Product summary card hero animation Feb 14, 2022
@M123-dev M123-dev mentioned this issue Mar 3, 2022
Closed
12 tasks
@teolemon teolemon changed the title Product summary card hero animation Add a hero animation to the product summary card Mar 18, 2022
@binoyPeries
Copy link
Contributor

binoyPeries commented Mar 21, 2022 •
edited
Loading

Hi @M123-dev , can i get more information regarding this? like what is the product summary card, and to what should we apply the hero animation ? Thank you

@M123-dev
Copy link
Member Author

M123-dev commented Mar 22, 2022 •
edited
Loading

Sure @binoyPeries, the card in the carousel in the scanner and the summary card (the top part of the product page) have large similarities, a Hero animation there could look nice

Screenshot_20220322-151258.jpg

Screenshot_20220322-151304.jpg

@Gagarod Gagarod mentioned this issue Mar 25, 2022
Merged
@g123k g123k linked a pull request Mar 26, 2022 that will close this issue
Added hero animation to the product summary card #1334
Merged
@teolemon teolemon mentioned this issue Mar 31, 2022
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
animations summary card
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added hero animation to the product summary card Gagarod/smooth-app
3 participants
@teolemon @M123-dev @binoyPeries