Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added hero animation to the product summary card #1334

Merged
merged 2 commits into from
Mar 26, 2022
Merged

Added hero animation to the product summary card #1334

merged 2 commits into from
Mar 26, 2022

Conversation

Gagarod
Copy link
Contributor

@Gagarod Gagarod commented Mar 25, 2022

What

  • Added hero animation to the product summary card

Screenshot

heroAnimation.mp4

Fixes bug(s)

Part of

@Gagarod Gagarod requested a review from a team as a code owner March 25, 2022 18:08
M123-dev
M123-dev reviewed Mar 25, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyy thanks @Gagarod the code looks good. Currently the automated tests are failing because of formatting. You can fix it by running flutter format . + I added a comment

packages/smooth_app/lib/pages/scan/scan_product_card.dart Outdated Show resolved Hide resolved
@g123k g123k linked an issue Mar 26, 2022 that may be closed by this pull request
Add a hero animation to the product summary card #1114
Closed
@Gagarod Gagarod requested a review from M123-dev March 26, 2022 10:28
M123-dev
M123-dev approved these changes Mar 26, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Gagarod

@M123-dev M123-dev merged commit e15720d into openfoodfacts:develop Mar 26, 2022
@M123-dev
Copy link
Member

Congrats on your first PR here @Gagarod 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees
No one assigned
Labels
animations summary card
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a hero animation to the product summary card
3 participants
@Gagarod @M123-dev @g123k