Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a way to move the Autofocus focus up ? #1384

Closed
Tracked by #1255
teolemon opened this issue Mar 29, 2022 · 6 comments · Fixed by #1579
Closed
Tracked by #1255

Is there a way to move the Autofocus focus up ? #1384

teolemon opened this issue Mar 29, 2022 · 6 comments · Fixed by #1579
Assignees
@g123k
Labels
🎯 P1 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Milestone
V1

Comments

@teolemon
Copy link
Member

teolemon commented Mar 29, 2022 •
edited
Loading

What

  • Is there a way to move the Autofocus focus up ? Can we set a focal point in the center of the visor ?

Video

Part of
@teolemon teolemon added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Mar 29, 2022
@M123-dev
Copy link
Member

That was actually what I meant in #1112 but yeah it would be good if we could change that

@teolemon teolemon mentioned this issue Mar 30, 2022
Open
@Pierre-Monier
Copy link
Contributor

I would like to work on that, but I can't assign myself to the issue :'(

@M123-dev
Copy link
Member

Here you go @Pierre-Monier

@Pierre-Monier
Copy link
Contributor

This seems complicated. There is a setFocusPoint method on the CameraController but I don't think it's working, or maybe I just don't get how this works. The current CameraValue has the attribute focusPointSupported to true, But setting the point at the top of the screen doesn't change a thing. Digging in the source doesn't really help. I don't think we are able to do that

@teolemon teolemon added this to the V1 milestone Apr 4, 2022
@teolemon teolemon mentioned this issue Apr 4, 2022
Closed
15 tasks
@g123k
Copy link
Collaborator

g123k commented Apr 4, 2022

Hi @Pierre-Monier,

As I also work on #1255, I think I can also fix this at the same time? Can I take it instead?

@Pierre-Monier
Copy link
Contributor

Yeah np ;)

@g123k g123k assigned g123k and unassigned Pierre-Monier Apr 4, 2022
@g123k g123k linked a pull request Apr 11, 2022 that will close this issue
fix: Camera improvements #1550
Closed
@g123k g123k mentioned this issue Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g123k g123k

Labels
🎯 P1 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1
4 participants
@g123k @teolemon @M123-dev @Pierre-Monier