Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Half image focus #1579

Merged
merged 2 commits into from
Apr 22, 2022
Merged

feat: Half image focus #1579

merged 2 commits into from
Apr 22, 2022

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Apr 15, 2022

When the barcode decoder uses the half image decoder, the camera should focus in this area.
Kind of fix #1384

@g123k g123k added the camera label Apr 15, 2022
@g123k g123k requested a review from a team as a code owner April 15, 2022 06:30
@github-actions github-actions bot added 🤳 MLKit 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… labels Apr 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1579 (5df70ce) into develop (2ea0da3) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #1579      +/-   ##
==========================================
- Coverage     8.86%   8.85%   -0.01%     
==========================================
  Files          161     161              
  Lines         6623    6629       +6     
==========================================
  Hits           587     587              
- Misses        6036    6042       +6     
Impacted Files Coverage Δ
...es/smooth_app/lib/pages/scan/ml_kit_scan_page.dart 0.90% <0.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea0da3...5df70ce. Read the comment docs.

@g123k g123k self-assigned this Apr 15, 2022
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm unable to tell from the documentation if a certain focus point doesn't just switch back to manual (That was my intuition when I first saw the setFocusPoint method) but let's try

@teolemon
Copy link
Member

good to merge ?

@g123k
Copy link
Collaborator Author

g123k commented Apr 22, 2022

@teolemon I think so

@M123-dev M123-dev merged commit 6bd6be3 into develop Apr 22, 2022
@M123-dev M123-dev deleted the camera_focus_half_image branch April 22, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
camera 🤳 MLKit 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Development

Successfully merging this pull request may close these issues.

Is there a way to move the Autofocus focus up ?
4 participants