Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad layout for hunger games card #4086

Closed
Tracked by #4019
monsieurtanuki opened this issue Jun 6, 2023 · 5 comments
Closed
Tracked by #4019

Bad layout for hunger games card #4086

monsieurtanuki opened this issue Jun 6, 2023 · 5 comments
Labels
🐛 bug Something isn't working Hunger Games

Comments

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Jun 6, 2023

What

  • The layout of the hunger games card is not relevant when the product name is very long (e.g. 3270160820146)
  • We cannot even see all the buttons.

Expected behavior

  • We should always see the 3 buttons (yes / no / maybe)
  • [edit]: should we use a scroll?

Part of

Screenshot/Mockup/Before-After

large product name edit: additional bad layout
Screenshot_2023-06-06-15-32-10 Screenshot_2023-06-06-16-31-57

Smartphone model

  • A smartphone will a small screen (samsung galaxy core prime)
@monsieurtanuki monsieurtanuki added the 🐛 bug Something isn't working label Jun 6, 2023
@g123k
Copy link
Collaborator

g123k commented Jun 10, 2023

Actually this screen is very weird as it contains a blank AppBar.
Shouldn't we use a dialog-like mode? I mean by that a semi-transparent background without any AppBar

Basically, that's how it's done in Google Maps.

@g123k
Copy link
Collaborator

g123k commented Jun 10, 2023

Here is a quick demo of what it could look like with a Dialog-like background:
untitled.webm

Is-it worth a PR? @teolemon / @monsieurtanuki

@monsieurtanuki
Copy link
Contributor Author

Your video looks good, but that doesn't solve any of the points of the OP.

@g123k
Copy link
Collaborator

g123k commented Jun 10, 2023

Your video looks good, but that doesn't solve any of the points of the OP.

By itself, it will provide a bigger screen size, but I've also forced the product name to fit in 3 lines
I will open in parallel the PR and we can discuss if we can improve this

@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k, I've just started to play Hunger Games with the new layout, and it looks great even on a 4.5" screen!
I'm about to create another issue, also on Hunger Games, instead of adding items to the current issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working Hunger Games
Development

No branches or pull requests

3 participants