Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Question page in a Dialog-like container (+ some fixes) #4109

Merged
merged 2 commits into from
Jun 10, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 10, 2023

Hi everyone,

This PR allows the question page to be more like Google Maps, but adding a background behind instead of a blank page.
I've also fixed the Ripple with the button 😇
And more specifically with #4086, the product name is limited to 3 lines

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2023

Codecov Report

Merging #4109 (03a8702) into develop (af9f28b) will decrease coverage by 0.02%.
The diff coverage is 1.38%.

@@             Coverage Diff             @@
##           develop    #4109      +/-   ##
===========================================
- Coverage    10.84%   10.83%   -0.02%     
===========================================
  Files          273      273              
  Lines        13516    13530      +14     
===========================================
  Hits          1466     1466              
- Misses       12050    12064      +14     
Impacted Files Coverage Δ
...pp/lib/cards/product_cards/product_title_card.dart 0.00% <ø> (ø)
...b/pages/hunger_games/question_answers_options.dart 0.00% <0.00%> (ø)
...ooth_app/lib/pages/hunger_games/question_card.dart 0.00% <0.00%> (ø)
...pages/preferences/user_preferences_contribute.dart 60.13% <0.00%> (+1.23%) ⬆️
...pp/lib/pages/product/product_questions_widget.dart 0.00% <0.00%> (ø)
...ooth_app/lib/pages/hunger_games/question_page.dart 1.01% <4.16%> (-0.23%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable. My true dream was/is #3549, which was merged, but does not work for some reason

@g123k
Copy link
Collaborator Author

g123k commented Jun 10, 2023

I've also improved the accessibility for this screen in a new commit.
A11n.webm

@g123k g123k changed the title feat: Question page in a Dialog-like background (+ some fixes) feat: Question page in a Dialog-like container (+ some fixes) Jun 10, 2023
@teolemon teolemon merged commit 386e6b6 into openfoodfacts:develop Jun 10, 2023
@g123k g123k deleted the question_page_dialog branch June 11, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants