Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User lists: "View on web" from the modal sheet redirects to the wrong link #4469

Closed
Tracked by #4463
g123k opened this issue Aug 7, 2023 · 0 comments · Fixed by #4482
Closed
Tracked by #4463

User lists: "View on web" from the modal sheet redirects to the wrong link #4469

g123k opened this issue Aug 7, 2023 · 0 comments · Fixed by #4482
Assignees
@g123k
Labels
🐛 bug Something isn't working User lists
Milestone
Version 4.9 (earl...

Comments

@g123k
Copy link
Collaborator

g123k commented Aug 7, 2023 •
edited by teolemon
Loading

Hi everyone,

For a user list, we have duplicated actions: both in the AppBar and in the "options" of the modal sheet.

From the AppBar, the link seems to be OK, but not with the other one.
Here is a demo: https://github.com/openfoodfacts/smooth-app/assets/246838/047b8811-8745-495a-934b-45f4cfbb418e

Part of
@g123k g123k added 🐛 bug Something isn't working User lists labels Aug 7, 2023
@g123k g123k mentioned this issue Aug 7, 2023
Closed
@g123k g123k self-assigned this Aug 8, 2023
@g123k g123k mentioned this issue Aug 8, 2023
Merged
@g123k g123k linked a pull request Aug 8, 2023 that will close this issue
fix: Many fixes for user lists in the modal sheet #4482
Merged
@teolemon teolemon added this to the Version 4.9 (early August) milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g123k g123k

Labels
🐛 bug Something isn't working User lists
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
Version 4.9 (early August)
Development

Successfully merging a pull request may close this issue.

fix: Many fixes for user lists in the modal sheet g123k/smooth-app
2 participants
@g123k @teolemon