Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error messages for registration should be improved for non-English languages #4471

Closed
Tracked by #4463
g123k opened this issue Aug 7, 2023 · 0 comments · Fixed by #4474
Closed
Tracked by #4463

Error messages for registration should be improved for non-English languages #4471

g123k opened this issue Aug 7, 2023 · 0 comments · Fixed by #4474
Assignees
@g123k
Labels
🐛 bug Something isn't working Sign-Up 👥 User management Account login, signup, signout
Milestone
Version 4.9 (earl...

Comments

@g123k
Copy link
Collaborator

g123k commented Aug 7, 2023

Hi everyone,

When we try to register an account with a non-english language, the Dart package sends directly the HTML.
As a quick fix, we can only show what's in the <li class="error"

IMG_1042

The benefit of it, it that we don't need to translate anything.
@g123k g123k added 🐛 bug Something isn't working 👥 User management Account login, signup, signout labels Aug 7, 2023
@g123k g123k mentioned this issue Aug 7, 2023
Closed
@g123k g123k linked a pull request Aug 7, 2023 that will close this issue
feat: Support non-english languages for Signup errors #4474
Merged
@g123k g123k self-assigned this Aug 8, 2023
@teolemon teolemon added this to the Version 4.9 (early August) milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g123k g123k

Labels
🐛 bug Something isn't working Sign-Up 👥 User management Account login, signup, signout
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
Version 4.9 (early August)
Development

Successfully merging a pull request may close this issue.

feat: Support non-english languages for Signup errors g123k/smooth-app
2 participants
@g123k @teolemon