Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When we change the language, the tagline is not refreshed #4666

Open
g123k opened this issue Sep 29, 2023 · 2 comments
Open

When we change the language, the tagline is not refreshed #4666

g123k opened this issue Sep 29, 2023 · 2 comments
Labels
fixed ? This bug might already be fixed. If so, close it. good first issue Good for newcomers tagline translations

Comments

@g123k
Copy link
Collaborator

g123k commented Sep 29, 2023

Hi everyone,

In the app, we can change the language and this may create some weird issues.
One of them is the fact that the tagline (= the news in the carousel) is still in the previous language.
So the fix, would be to force the refresh during a language change.

Steps to reproduce:

  1. Open the app and see the tagline (if you don't see it, you need to scan at least one product and reopen the app)
  2. Set the app to a different language
  3. The tagline still uses the old language

Video:

RPReplay_Final1696014437.2.MP4
@Kaps61929
Copy link

@teolemon I would love to contribute to this issue. Please assign it to me.

@teolemon teolemon assigned Kaps61929 and unassigned Kaps61929 Jan 27, 2024
@teolemon
Copy link
Member

It seems it's been solved @Kaps61929
#4687

@teolemon teolemon added the fixed ? This bug might already be fixed. If so, close it. label Jan 27, 2024
@teolemon teolemon removed the 🐛 bug Something isn't working label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed ? This bug might already be fixed. If so, close it. good first issue Good for newcomers tagline translations
Projects
Status: 💬 To discuss and validate
Development

Successfully merging a pull request may close this issue.

3 participants