fix: Tagline language refresh #4687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert Tagline widget to StatefulWIdget. Tagline didn't refresh, after language was changed.
Codecov Report
@@ Coverage Diff @@
## develop #4687 +/- ##
==========================================
- Coverage 9.91% 9.90% -0.01%
==========================================
Files 310 310
Lines 15795 15794 -1
==========================================
- Hits 1566 1565 -1
Misses 14229 14229
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
g123k
requested changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Tagline didn't refresh, after language was changed. Convert Tagline widget to StatefulWidget.
I'm not sure if there are better ways to fix this. I'm not the most experienced Flutter developer. Please let me know what you think and I can update it accordingly otherwise.
Screenshot
untitled.webm
Fixes bug(s)
Fixes #4666