Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the product page we can remove the Complete category, since we now have the fast track pipeline that does the same. #4697

Closed
teolemon opened this issue Oct 4, 2023 · 10 comments · Fixed by #4937
Labels
good first issue Good for newcomers 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.

Comments

@teolemon
Copy link
Member

teolemon commented Oct 4, 2023

What

  • On the product page we can remove the Complete category, since we now have the fast track pipeline that does the same.

Screenshot

Screenshot_20231004-103402.png

@teolemon teolemon added 🐛 bug Something isn't working 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users. labels Oct 4, 2023
@teolemon teolemon changed the title placeholder On the product page we can remove the Complete category, since we now have the fast track pipeline that does the same. Oct 4, 2023
@monsieurtanuki monsieurtanuki added good first issue Good for newcomers and removed 🐛 bug Something isn't working labels Oct 4, 2023
@malik-vishu
Copy link
Contributor

@monsieurtanuki @teolemon Can you assign this to me?

@malik-vishu
Copy link
Contributor

@monsieurtanuki Thank you

@malik-vishu
Copy link
Contributor

@teolemon Can you tell me how did you get this screen. I am not seeing any button here.
image

@malik-vishu
Copy link
Contributor

@teolemon It's showing on very few items.
image

@monsieurtanuki
Copy link
Contributor

@malik-vishu It's like an optional button, "if the category is not set then show an add-category button".
I think it's called an "action button" in the code.

@malik-vishu
Copy link
Contributor

@monsieurtanuki I am a bit lost here. Could you help me in locating the file for this screen?

@monsieurtanuki
Copy link
Contributor

Would be in https://github.com/openfoodfacts/smooth-app/blob/develop/packages/smooth_app/lib/knowledge_panel/knowledge_panels/knowledge_panel_action_card.dart

Here we should not react to the "addCategories" action anymore, because it's now dealt with somewhere else (by the fast-track button).

@malik-vishu
Copy link
Contributor

@monsieurtanuki Ok thanks.

@malik-vishu
Copy link
Contributor

@M123-dev
Copy link
Member

Could you be a bit more specific @malik-vishu what is not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.
Development

Successfully merging a pull request may close this issue.

4 participants