Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 4697 - no more redundant "complete category" button #4937

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Removed the redundant "complete category" button in product summary card (redundant with the fast-track button).

Screenshot

before after
Screenshot_1704114355 Screenshot_1704114509

Fixes bug(s)

@monsieurtanuki
Copy link
Contributor Author

@malik-vishu For the record, this was how to fix the issue.

@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72ac084) 9.65% compared to head (d9b3e6e) 9.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #4937   +/-   ##
=======================================
  Coverage     9.65%   9.65%           
=======================================
  Files          323     323           
  Lines        16207   16202    -5     
=======================================
  Hits          1564    1564           
+ Misses       14643   14638    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monsieurtanuki monsieurtanuki merged commit bcf9356 into openfoodfacts:develop Jan 7, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants