Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad logos for "Signal a problem" in offline #5436

Closed
monsieurtanuki opened this issue Jun 23, 2024 · 0 comments · Fixed by #5475
Closed

Bad logos for "Signal a problem" in offline #5436

monsieurtanuki opened this issue Jun 23, 2024 · 0 comments · Fixed by #5475
Assignees
Labels
asset cache cached assets (SVG…) for the knowledge panels 🐛 bug Something isn't working fixed ? This bug might already be fixed. If so, close it. good first issue Good for newcomers 📖 Knowledge panels

Comments

@monsieurtanuki
Copy link
Contributor

What

  • On the product page, at the end there's a "Signal a problem" card.
  • This card doesn't display well offline in dark mode:
    • the OFF icon is not adapted to dark mode (probably because the server doesn't return a distinct icon for light and dark)
    • the "Signal conso" logo is not displayed (probably because it's not in the local assets icons)

Steps to reproduce the behavior

  1. Close the app
  2. Put your device in offline mode
  3. Start the app
  4. Switch to dark mode at the app level
  5. Go to a recent product page
  6. Scroll down to the bottom of that page, to the "Signal conso" card
  7. The icons don't look well

Screenshot/Mockup/Before-After

Dark
Screenshot_20240623_080830

Light
Screenshot_20240623_082302

@monsieurtanuki monsieurtanuki added good first issue Good for newcomers 🐛 bug Something isn't working labels Jun 23, 2024
@teolemon teolemon added 📖 Knowledge panels asset cache cached assets (SVG…) for the knowledge panels fixed ? This bug might already be fixed. If so, close it. labels Jul 4, 2024
@g123k g123k self-assigned this Jul 4, 2024
@g123k g123k linked a pull request Jul 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asset cache cached assets (SVG…) for the knowledge panels 🐛 bug Something isn't working fixed ? This bug might already be fixed. If so, close it. good first issue Good for newcomers 📖 Knowledge panels
Development

Successfully merging a pull request may close this issue.

3 participants