Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Raster cache should support ErrorBuilder #5475

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 4, 2024

Hi everyone!

As noticed by @monsieurtanuki, the Signal Conso logo is not working offline, even if it's in the cache assets.
The reason was that the error callback was not fetching the image in the cache

@g123k g123k requested a review from a team as a code owner July 4, 2024 15:55
@g123k g123k linked an issue Jul 4, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 7.16%. Comparing base (4d9c7fc) to head (2652c16).
Report is 243 commits behind head on develop.

Files Patch % Lines
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5475      +/-   ##
==========================================
- Coverage     9.54%   7.16%   -2.39%     
==========================================
  Files          325     391      +66     
  Lines        16411   20404    +3993     
==========================================
- Hits          1567    1462     -105     
- Misses       14844   18942    +4098     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @g123k!
Please consider avoiding copy/paste, for maintenance reasons.

@g123k
Copy link
Collaborator Author

g123k commented Jul 5, 2024

Hi @g123k! Please consider avoiding copy/paste, for maintenance reasons.

Good point!
Should be OK now 🫢

@monsieurtanuki monsieurtanuki merged commit 68e8140 into openfoodfacts:develop Jul 5, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor

Thank you @g123k for the quick improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Bad logos for "Signal a problem" in offline
3 participants