Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable non-food products editing temporarily (until we tweak editing) #5643

Closed
teolemon opened this issue Sep 28, 2024 · 4 comments
Closed
Assignees
Labels
🧴 Open Beauty Facts Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378 🐾 Open Pet Food Facts 📸 Open Products Facts OxF

Comments

@teolemon
Copy link
Member

Disable non-food products editing temporarily (until we tweak editing)

Please keep in mind that we still cannot edit non-food products - that would probably create food products from scratch.

Originally posted by @monsieurtanuki in #5637 (comment)

@monsieurtanuki monsieurtanuki self-assigned this Sep 28, 2024
@monsieurtanuki monsieurtanuki added 🧴 Open Beauty Facts Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378 📸 Open Products Facts 🐾 Open Pet Food Facts OxF labels Sep 28, 2024
@monsieurtanuki
Copy link
Contributor

Actually I'm about to add the editing of non-food products instead.

@monsieurtanuki
Copy link
Contributor

@teolemon Obviously tons on data edit buttons about new non-food products should be removed, depending on the product type.
Which options should we remove, and in which cases?

photos nutriscore
image image
ecoscore nova
image image
details details' details
image image

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Oct 3, 2024

@teolemon If I sum up

  • no ingredients (OPF)
  • no ingredients photo (OPF)
  • no nutrition facts (OBF, OPF)
  • no nutrition photo (OBF, OPF)
  • no road to score (OBF, OPF)
  • no nutriscore (OBF, OPF, OPFF)
  • no ecoscore (OBF, OPF, OPFF)
  • no nova (OBF, OPF, OPFF)

And more specifically for the "Found new product!" pages:

  • no "Ecoscore" page (OBF, OPF, OPFF)
  • no "Nova" page (OBF, OPF, OPFF)
  • the "Nutriscore" page makes no sense, and could be turned into a "category", "ingredients?", "nutrition?" and "basic details" single page (OBF, OPF, OPFF)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧴 Open Beauty Facts Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378 🐾 Open Pet Food Facts 📸 Open Products Facts OxF
Development

No branches or pull requests

2 participants