feat: 5643 - removed irrelevant editors for non-FOOD products

[monsieurtanuki]

What

• now the main image fields depend on product type (e.g. no nutrition and ingredients for PRODUCTS)
• no ingredient editor for PRODUCTS in the edit product page
• one single editor page for new found products that are not FOOD

Screenshots

PRODUCTS (no ingredients, no nutrition)	BEAUTY (no nutrition)

Part of

• Disable non-food products editing temporarily (until we tweak editing) #5643

Impacted files

• add_new_product_page.dart: editors different when not FOOD; minor refactoring
• edit_product_page.dart: no ingredient editor for PRODUCTS
• image_field_extension.dart: now the main image fields depend on product type; minor refactoring (more compact switch syntax)
• knowledge_panels_builder.dart: minor fix
• product_cards_helper.dart: now the main image fields depend on product type
• product_image_gallery_view.dart: now the main image fields depend on product type
• product_image_swipeable_view.dart: now the main image fields depend on product type

[teolemon]

The screenshot actually illustrate the corner cases

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 90 lines in your changes missing coverage. Please review.

Project coverage is 6.85%. Comparing base (4d9c7fc) to head (2becf35).
Report is 342 commits behind head on develop.

Files with missing lines	Patch %	Lines
...th_app/lib/pages/product/add_new_product_page.dart	0.00%	43 Missing ⚠️
.../smooth_app/lib/helpers/image_field_extension.dart	0.00%	30 Missing ⚠️
...mooth_app/lib/pages/product/edit_product_page.dart	0.00%	5 Missing ⚠️
.../lib/knowledge_panel/knowledge_panels_builder.dart	0.00%	4 Missing ⚠️
.../lib/pages/product/product_image_gallery_view.dart	0.00%	4 Missing ⚠️
...s/smooth_app/lib/helpers/product_cards_helper.dart	0.00%	2 Missing ⚠️
...ib/pages/product/product_image_swipeable_view.dart	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #5663      +/-   ##
==========================================
- Coverage     9.54%   6.85%   -2.70%     
==========================================
  Files          325     402      +77     
  Lines        16411   21395    +4984     
==========================================
- Hits          1567    1466     -101     
- Misses       14844   19929    +5085     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[monsieurtanuki]

The screenshot actually illustrate the corner cases

@teolemon Not sure I understand what you mean.

[teolemon]

• Detergents are one of the few OPF categories where there can be ingredients
• toothpaste is one of the few cosmetics categories where there can be what is similar to a nutrient, that is to say the parts per 1000 of fluoride

[monsieurtanuki]

@teolemon How does it work with the legacy apps?

[teolemon]

We were more liberal and kept ingredients for OPF.

[monsieurtanuki]

Thank you @teolemon for your review!

I guess we'll have to fine-tune the concept of "other products".
There are classes of products that have expected/mandatory features, like diagonal size for smartphones or fluoride for toothpaste. How could we nudge users into entering expected (folksonomy) values (I mean, related to expected keys)?

[monsieurtanuki]

Thank you @teolemon for your review!

I guess we'll have to fine-tune the concept of "other products". There are classes of products that have expected/mandatory features, like diagonal size for smartphones or fluoride for toothpaste. How could we nudge users into entering expected (folksonomy) values (I mean, related to expected keys)?

From the category I guess: somehow maintaining a list of expected features for a given product category.