Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep links from Google Search are broken #5702

Closed
teolemon opened this issue Oct 17, 2024 · 2 comments · Fixed by #5706
Closed

Deep links from Google Search are broken #5702

teolemon opened this issue Oct 17, 2024 · 2 comments · Fixed by #5706
Assignees
@g123k
Labels
🔗 Deeplinking Ensure people browsing Open Food Facts on the mobile web have a bridge to the mobile apps 🎯 P0 router

Comments

@teolemon
Copy link
Member

What

  • Deep links from Google Search are broken

Steps to reproduce the behavior

  1. Go to Google Search
  2. Search for open food facts
  3. Click on a deeplink
  4. See error

Expected behavior

  • It should open the right page in the webview
  • NOTE: I should check if my link capture is enabled on Android, but even if it is, it should not fail like that, and now that I think of if, the capture happened, the routing just didn't work, possibly because of an extra param added by Google or something ?

Why

  • Path to apps, reengagements, 1st time XP

Part of

Screenshot/Mockup/Before-After

Image
Image
Image
@teolemon teolemon added router 🎯 P0 🔗 Deeplinking Ensure people browsing Open Food Facts on the mobile web have a bridge to the mobile apps labels Oct 17, 2024
@monsieurtanuki
Copy link
Contributor

@teolemon On my smartphone from "en savoir plus sur le nutriscore" I land on a web page in my browser.

@g123k
Copy link
Collaborator

g123k commented Oct 17, 2024

@teolemon Could you provide the list of faulty URLs?

@g123k g123k self-assigned this Oct 17, 2024
@g123k g123k mentioned this issue Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g123k g123k

Labels
🔗 Deeplinking Ensure people browsing Open Food Facts on the mobile web have a bridge to the mobile apps 🎯 P0 router
Projects
🎯 Very high impact issues
Status: Done
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Status: 🎊 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: GoRouter doesn't like subroutes for external links g123k/smooth-app
3 participants
@g123k @teolemon @monsieurtanuki