Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GoRouter doesn't like subroutes for external links #5706

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Oct 18, 2024

Hi everyone,

I don't really understand why, but for the external links, GoRouter only works with:

  • Path parameters and not queries
  • The route must be a root one and not a sub route of /

I will fix #5702

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 6.79%. Comparing base (4d9c7fc) to head (dde826e).
Report is 362 commits behind head on develop.

Files with missing lines Patch % Lines
.../smooth_app/lib/pages/navigator/app_navigator.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5706      +/-   ##
==========================================
- Coverage     9.54%   6.79%   -2.76%     
==========================================
  Files          325     404      +79     
  Lines        16411   21578    +5167     
==========================================
- Hits          1567    1466     -101     
- Misses       14844   20112    +5268     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon added 🔗 Deeplinking Ensure people browsing Open Food Facts on the mobile web have a bridge to the mobile apps router labels Oct 18, 2024
@teolemon teolemon merged commit 4025f30 into openfoodfacts:develop Oct 18, 2024
6 checks passed
@teolemon
Copy link
Member

thanks @g123k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔗 Deeplinking Ensure people browsing Open Food Facts on the mobile web have a bridge to the mobile apps router
Development

Successfully merging this pull request may close these issues.

Deep links from Google Search are broken
4 participants