-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Action bar for the product (+ light redesign) #5749
feat: Action bar for the product (+ light redesign) #5749
Conversation
(cherry picked from commit cb50d79)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have perhaps used something more scalable for the currency icons, since they are well supported in fonts, but we can refactor at a later point 👍
There is a reason for that:
I know this is not perfect, but the other solutions are as bad as this one. |
Hi everyone!
This PR changes multiple things on the product page.
First, regarding code,
new_product_page.dart
is in a dedicated folder calledpages/product/product_page
. This is because there is now anew_product_footer.dart
in this directory.Regarding the UI, there are many changes:
The "Add to a list" feature is still as before (with dialogs). It will be redesigned in an upcoming PR.
Part of #5739