Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improvements for the product page (Part 2) #5764

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Oct 28, 2024

Hi everyone!

After #5749, there were some minor details to fix.
Here's the list:

  • Subtitles now are… subtitles (= with a bigger size and a darker font)
    IMG_1255 copy

  • The action bar has a darker shadow + more paddings on Android
    IMG_1255

  • All sections have equal spacings (+ no more blank spacing at the end)
    IMG_1256

  • Websites and Prices blocks share the same title layout as Health/Environment
    IMG_1256

And the same goes for dark mode:
IMG_1252
IMG_1254

  • Some refactored code

@g123k g123k linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @g123k 👍

@teolemon teolemon merged commit 688ddc2 into openfoodfacts:develop Oct 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

UI improvements for the product page
2 participants