Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Contribute cupertino bottom modal sheet UI fix. #1278

Merged
merged 1 commit into from
Mar 20, 2022
Merged

fix: Contribute cupertino bottom modal sheet UI fix. #1278

merged 1 commit into from
Mar 20, 2022

Conversation

abhay1821
Copy link
Contributor

What

  • This PR includes the fixes for the UI rendering in the contribute Cupertino bottom modal sheet which breaks on devices with smaller dimensions

Screenshot

Small Samsung Galaxay S20 One Plus 8 Pro
Redmi Note 7 Pro Medium iPhone SE
iPhone 12 mini iPHONE 13 mini iPhone 12
iPhone 13

Fixes bug(s)

Part of

@abhay1821 abhay1821 requested a review from a team as a code owner March 20, 2022 16:19
@abhay1821
Copy link
Contributor Author

@teolemon or @M123-dev could you approve the workflow to run since I am a first-time contributor.

M123-dev
M123-dev approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @abhay1821

@M123-dev M123-dev linked an issue Mar 20, 2022 that may be closed by this pull request
bug: Render issue in Contribute Cupertino Modal Bottom Sheet #1277
Closed
@M123-dev M123-dev merged commit 19f7c23 into openfoodfacts:develop Mar 20, 2022
@github-actions github-actions bot mentioned this pull request Mar 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Render issue in Contribute Cupertino Modal Bottom Sheet
2 participants
@abhay1821 @M123-dev