Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes for the UI rendering in the "Contributors" Smooth Alert box sheet #1281

Merged
merged 2 commits into from
Mar 21, 2022
Merged

fix: fixes for the UI rendering in the "Contributors" Smooth Alert box sheet #1281

merged 2 commits into from
Mar 21, 2022

Conversation

abhay1821
Copy link
Contributor

What

  • This PR includes the fixes for the UI rendering in the contribut Smooth Alert box sheet which breaks on devices with smaller dimensions

Screenshot

Small One Plus 8 Pro

Fixes bug(s)

Part of

@abhay1821 abhay1821 requested a review from a team as a code owner March 21, 2022 06:30
@abhay1821
Copy link
Contributor Author

@M123-dev could you approve the workflow

@teolemon teolemon changed the title Smooth alert branch fix: fixes for the UI rendering in the "Contributors" Smooth Alert box sheet Mar 21, 2022
M123-dev
M123-dev approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @abhay1821

@M123-dev M123-dev merged commit 6df17e8 into openfoodfacts:develop Mar 21, 2022
@github-actions github-actions bot mentioned this pull request Mar 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees
No one assigned
Labels
⚙️ Settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhay1821 @M123-dev @teolemon