Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Welcome message split fixed in smaller device width phones #1441

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

abhay1821
Copy link
Contributor

What

  • This PR includes the fix of the Welcome message split issue in smaller device-width

Screenshot

Small Samsung Galaxy S20 One Plus 8 Pro

Fixes bug(s)

Part of

@abhay1821 abhay1821 requested a review from a team as a code owner April 1, 2022 14:55
@abhay1821
Copy link
Contributor Author

Hi @M123-dev Could Please review it

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can't really think of a better solution

@M123-dev M123-dev merged commit 475534c into openfoodfacts:develop Apr 1, 2022
@abhay1821
Copy link
Contributor Author

Thank You for your review @M123-dev. So Actually had a discussion with monsieurtanuki. So we often find text-overflow problems with different phones sizes . And sometimes using FittedBox itself brings up its own repercussion. Using this package can fix all our overflow problems throughout the App ;)

@monsieurtanuki
Copy link
Contributor

@abhay1821 I agree with you, now that you've embedded auto_size_text, I guess we should definitely use it on other screens.

Perhaps we should play a bit with it, before spreading its use to the rest of the app:

  • typical values for the font size (e.g. double.infinity?)
  • typical max number of lines
  • typical restriction (width or height?)

Looks like a good improvement anyway!

@abhay1821 abhay1821 deleted the welcomesplit branch April 2, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants