feat: #1022 - tap to switch to search card ("Welcome to Open Food Facts") #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
M123-dev
approved these changes
Apr 6, 2022
| @@ -60,7 +60,7 @@ class ContinuousScanModel with ChangeNotifier { | |||
| _states.clear(); | |||
| _latestScannedBarcode = null; | |||
| await refreshProductList(); | |||
| for (final String barcode in _productList.barcodes.reversed) { | |||
| @@ -34,6 +35,7 @@ class PageManagerState extends State<PageManager> { | |||
| }; | |||
|
|
|||
| BottomNavigationTab _currentPage = BottomNavigationTab.Scan; | |||
| List<Widget> _tabs = <Widget>[]; | |||
There was a problem hiding this comment.
Is there anything stopping you from directly adding all the _buildOffstageNavigator's up here
There was a problem hiding this comment.
To be frank, I don't have a MUST reason to put it here😄
| } | ||
| } | ||
|
|
||
| class _InheritedDataManagerProvider extends InheritedWidget { |
There was a problem hiding this comment.
We are using Provider for state managment, what about using it to keep the code consistent
There was a problem hiding this comment.
I need to pass a flag from page_manager to scan_carousel, InheritedWidget might be a better approach to prevent adding params to constructors or rebuilding the whole tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
rpreplay-final1649246863_pA2IhwoI.mp4
Fixes bug(s)
Part of