feat: Remove individual product from the scan carousel

[bhattabhi013]

What

Added a clear button to remove an individual product from the list of scanned products.

Video

1295.mp4

Fixes bug(s)

• The cross needed to remove one product from the product carousel is missing #1295

Part of

• Launch Blocking (and nice to have) Smoothie features #655

[monsieurtanuki]

@bhattabhi013 Please use recent method from DaoProductList instead of the pop you introduced:

  /// Adds or removes a barcode within a product list (depending on [include])
  ///
  /// Returns true if there was a change in the list.
  Future<bool> set(
    final ProductList productList,
    final String barcode,
    final bool include,
  )

[monsieurtanuki]

Looks good @bhattabhi013!
Minor comments.
The main thing is to get rid of your pop method in DaoProductList, that is now redundant with a recent method (that probably didn't exist when you started).

[teolemon]

• Not sure why we put the weight on the right (vs the Mockups) and thus can't put the cross on the left.
• If in the red bar, it might send the message it will remove the red bar only.
• Also, I expect it to be at the same distance from the right as the product name/brand are from the left.

[bhattabhi013]

• Not sure why we put the weight on the right (vs the Mockups) and thus can't put the cross on the left.
• If in the red bar, it might send the message it will remove the red bar only.
• Also, I expect it to be at the same distance from the right as the product name/brand is from the left.

• I'll place the cross icon on the left.
• I'm not sure about the second point.
• I'll fix this and change the distance as suggested.

[codecov-commenter]

Codecov Report

Merging #1662 (4770577) into develop (2ea0da3) will decrease coverage by 0.54%.
The diff coverage is 0.37%.

@@            Coverage Diff             @@
##           develop   #1662      +/-   ##
==========================================
- Coverage     8.86%   8.31%   -0.55%     
==========================================
  Files          161     165       +4     
  Lines         6623    7116     +493     
==========================================
+ Hits           587     592       +5     
- Misses        6036    6524     +488     

Impacted Files	Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart	0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart	0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart	0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart	0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart	0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart	0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_card.dart	0.00% <0.00%> (ø)
...rds/knowledge_panels/knowledge_panels_builder.dart	2.17% <ø> (ø)
...pp/lib/cards/product_cards/product_title_card.dart	0.00% <0.00%> (ø)
...cards/product_cards/smooth_product_card_found.dart	0.00% <0.00%> (ø)
... and 41 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbc2aca...4770577. Read the comment docs.

[teolemon]

@bhattabhi013 i was tired, cross on the right, see the original bug with mockup for reference

[monsieurtanuki]

Thank you @bhattabhi013!
I haven't understood where the cross icon is finally supposed to be, but as far as I'm concerned it's good!

[teolemon]

[bhattabhi013]

Hi everyone,
Here is the screenshot of the updated UI as suggested by @teolemon.

[teolemon]

We can harmonize the fontsize of weight perhaps, but LGTM 👍

[teolemon]

merged, thanks @bhattabhi013