Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moved to product onboarding references about knowledge panels #1710

Merged
merged 1 commit into from
Apr 30, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Deleted file:

  • sample_knowledge_panels.json: now part of sample_product_data.json

Impacted files:

  • knowledge_panel_page_template.dart: now using full product instead of just knowledge panels
  • onboarding_data_product.dart: removed knowledge panels references as they're part of product now
  • onboarding_loader.dartremoved knowledge panels references
  • sample_product_data.json: refreshed data including knowledge panels

What

  • From feat: knowledgePanels are now loaded with the other product fields #1691 we consider knowledge panels as a default field of products.
  • That simplifies hugely the download of knowledge panels - it's now transparently done from product data download.
  • That's also the case for the onboarding, where we previously accessed the back-end twice, once for product, once for knowledge panels.
  • This PR is about downloading product and knowledge panels data in just one shot.

Deleted file:
* `sample_knowledge_panels.json`: now part of `sample_product_data.json`

Impacted files:
* `knowledge_panel_page_template.dart`: now using full product instead of just knowledge panels
* `onboarding_data_product.dart`: removed knowledge panels references as they're part of product now
* `onboarding_loader.dart`removed knowledge panels references
* `sample_product_data.json`: refreshed data including knowledge panels
@codecov-commenter
Copy link

Codecov Report

Merging #1710 (16a95f9) into develop (2ea0da3) will decrease coverage by 0.56%.
The diff coverage is 0.68%.

@@            Coverage Diff             @@
##           develop   #1710      +/-   ##
==========================================
- Coverage     8.86%   8.30%   -0.57%     
==========================================
  Files          161     165       +4     
  Lines         6623    7119     +496     
==========================================
+ Hits           587     591       +4     
- Misses        6036    6528     +492     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_page.dart 0.00% <0.00%> (ø)
...s/knowledge_panels/knowledge_panel_table_card.dart 0.00% <0.00%> (ø)
...pp/lib/cards/product_cards/product_title_card.dart 0.00% <0.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb3b0e...16a95f9. Read the comment docs.

@teolemon teolemon added this to the V1 milestone Apr 29, 2022
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monsieurtanuki monsieurtanuki merged commit 1847d2d into openfoodfacts:develop Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants