Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Night mode: force the adaptive icon on Android 26+ #1938

Merged
merged 1 commit into from
May 23, 2022

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented May 23, 2022

On Android and in night mode, force the adaptive icon.
Will fix #1931

@g123k g123k requested a review from a team as a code owner May 23, 2022 09:02
@g123k g123k self-assigned this May 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1938 (6bdfc0c) into develop (2ea0da3) will decrease coverage by 0.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #1938      +/-   ##
==========================================
- Coverage     8.86%   8.30%   -0.56%     
==========================================
  Files          161     178      +17     
  Lines         6623    8249    +1626     
==========================================
+ Hits           587     685      +98     
- Misses        6036    7564    +1528     
Impacted Files Coverage Δ
...lib/animations/smooth_animated_collapse_arrow.dart 0.00% <0.00%> (-100.00%) ⬇️
...kages/smooth_app/lib/widgets/attribute_button.dart 0.00% <0.00%> (-92.00%) ⬇️
packages/smooth_app/lib/themes/smooth_theme.dart 58.82% <0.00%> (-24.16%) ⬇️
...s/smooth_app/lib/data_models/user_preferences.dart 16.17% <0.00%> (-16.14%) ⬇️
...mooth_app/lib/data_models/product_preferences.dart 26.47% <0.00%> (-4.96%) ⬇️
packages/smooth_app/lib/main.dart 15.74% <0.00%> (-2.16%) ⬇️
...smooth_app/lib/pages/product/new_product_page.dart 0.00% <0.00%> (-0.88%) ⬇️
...rds/knowledge_panels/knowledge_panels_builder.dart 1.88% <0.00%> (-0.29%) ⬇️
...es/smooth_app/lib/cards/data_cards/score_card.dart 4.54% <0.00%> (-0.22%) ⬇️
.../smooth_app/lib/pages/onboarding/welcome_page.dart 2.94% <0.00%> (-0.19%) ⬇️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49ee3c5...6bdfc0c. Read the comment docs.

@g123k g123k added the icon label May 23, 2022
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @g123k

@M123-dev M123-dev merged commit a95d38c into openfoodfacts:develop May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with the new icon
4 participants