Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Autopause camera after 1 min of inactivity #2229

Merged
merged 4 commits into from
Jun 9, 2022

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 8, 2022

Demo (with a timeout of 5 seconds):

flash.mp4

Will fix #2199

@g123k g123k requested a review from a team as a code owner June 8, 2022 19:44
@g123k g123k self-assigned this Jun 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2022

Codecov Report

Merging #2229 (011afd1) into develop (2ea0da3) will decrease coverage by 1.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2229      +/-   ##
==========================================
- Coverage     8.86%   7.72%   -1.14%     
==========================================
  Files          161     181      +20     
  Lines         6623    9098    +2475     
==========================================
+ Hits           587     703     +116     
- Misses        6036    8395    +2359     
Impacted Files Coverage Δ
...kages/smooth_app/lib/widgets/attribute_button.dart 0.00% <0.00%> (-92.00%) ⬇️
packages/smooth_app/lib/themes/smooth_theme.dart 60.00% <0.00%> (-22.98%) ⬇️
...s/smooth_app/lib/data_models/user_preferences.dart 9.37% <0.00%> (-22.94%) ⬇️
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 19.23% <0.00%> (-14.98%) ⬇️
...mooth_app/lib/data_models/product_preferences.dart 26.47% <0.00%> (-4.96%) ⬇️
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% <0.00%> (-3.13%) ⬇️
.../smooth_app/lib/pages/onboarding/scan_example.dart 0.00% <0.00%> (-2.28%) ⬇️
packages/smooth_app/lib/main.dart 15.74% <0.00%> (-2.16%) ⬇️
...s/smooth_app/lib/pages/onboarding/next_button.dart 2.22% <0.00%> (-1.78%) ⬇️
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% <0.00%> (-1.57%) ⬇️
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e335b9a...011afd1. Read the comment docs.

@teolemon
Copy link
Member

teolemon commented Jun 8, 2022

"To save energy"

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I would assume that the timer restarts when I scan a product, but that's not a blocking thing. This feature addition is great

@g123k
Copy link
Collaborator Author

g123k commented Jun 9, 2022

And… implemented :)

  • editing the Dialog content

@teolemon teolemon merged commit 72edce1 into openfoodfacts:develop Jun 9, 2022
@VaiTon
Copy link
Member

VaiTon commented Jun 9, 2022

Good work @g123k ! 🎉

g123k added a commit that referenced this pull request Jun 9, 2022
M123-dev pushed a commit that referenced this pull request Jun 9, 2022
@g123k g123k deleted the autopause_camera branch June 22, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pause camera feed after inactivity
5 participants