Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1427 scanning invalid code #2336

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

cli1005
Copy link
Contributor

@cli1005 cli1005 commented Jun 20, 2022

What

If the scanned barcode is invalid, the code in FetchedStatus will be empty as follows:
{status: 0, code: , status_verbose: no code or invalid code, product: null}
In this case a little message will show lto avoid wasting time in creating and uploading

Screenshot

Image

Fixes bug(s)

Part of

@cli1005 cli1005 requested a review from a team as a code owner June 20, 2022 10:56
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@teolemon teolemon added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Jun 21, 2022
@teolemon
Copy link
Member

thanks @cli1005 👍

@teolemon teolemon merged commit 5715cf7 into openfoodfacts:develop Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Development

Successfully merging this pull request may close these issues.

(Product addition) Trying to scan non standard barcodes has a disappointing experience
3 participants