Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 3507 - added mandatory icons and optional hints to packagings #3514

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

monsieurtanuki
Copy link
Contributor

New files:

  • counter-dark.svg
  • counter-light.svg
  • material.svg
  • quantity.svg
  • recycling.svg
  • shape.svg
  • weight.svg

Impacted files:

  • app_en.arb: added hint labels for material and weight
  • edit_new_packagings.dart: added mandatory icons and optional hints
  • explanation_widget.dart: unrelated refactoring
  • pubspec.yaml: added a dedicated asset folder for packagings
  • simple_input_widget.dart: unrelated refactoring

What

  • On the structured packagings page
    • an icon at the start
    • a hint for material and weight

Screenshot

dark light
Capture d’écran 2023-01-04 à 15 37 44 Capture d’écran 2023-01-04 à 15 38 20

Part of

New files:
* `counter-dark.svg`
* `counter-light.svg`
* `material.svg`
* `quantity.svg`
* `recycling.svg`
* `shape.svg`
* `weight.svg`

Impacted files:
* `app_en.arb`: added hint labels for material and weight
* `edit_new_packagings.dart`: added mandatory icons and optional hints
* `explanation_widget.dart`: unrelated refactoring
* `pubspec.yaml`: added a dedicated asset folder for packagings
* `simple_input_widget.dart`: unrelated refactoring
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #3514 (c508071) into develop (f528b31) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3514      +/-   ##
===========================================
- Coverage    11.08%   11.08%   -0.01%     
===========================================
  Files          262      262              
  Lines        12941    12951      +10     
===========================================
  Hits          1435     1435              
- Misses       11506    11516      +10     
Impacted Files Coverage Δ
...oth_app/lib/pages/product/edit_new_packagings.dart 0.00% <0.00%> (ø)
...ooth_app/lib/pages/product/explanation_widget.dart 0.00% <0.00%> (ø)
...oth_app/lib/pages/product/simple_input_widget.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@monsieurtanuki monsieurtanuki merged commit 3cf4534 into openfoodfacts:develop Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants