Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 3783 - brought back the old visor #3785

Closed
wants to merge 1 commit into from
Closed

feat: 3783 - brought back the old visor #3785

wants to merge 1 commit into from

Conversation

monsieurtanuki
Copy link
Contributor

New file:

  • smooth_barcode_scanner_visor.dart: Barcode Scanner Visor widget.

Impacted files:

  • smooth_barcode_scanner_mlkit.dart: now using the new SmoothBarcodeScannerVisor widget
  • smooth_barcode_scanner_zxing.dart: now using the new SmoothBarcodeScannerVisor widget

What

Screenshot

before (zxing) after (zxing) after (mlkit)
Screenshot_2023-03-19-09-04-54 Screenshot_2023-03-19-09-17-04 Screenshot_2023-03-19-09-16-31

Fixes bug(s)

@monsieurtanuki
feat: 3783 - brought back the old visor
edd9f4c 
New file:
* `smooth_barcode_scanner_visor.dart`: Barcode Scanner Visor widget.

Impacted files:
* `smooth_barcode_scanner_mlkit.dart`: now using the new `SmoothBarcodeScannerVisor` widget
* `smooth_barcode_scanner_zxing.dart`: now using the new `SmoothBarcodeScannerVisor` widget
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner March 19, 2023 08:31
@github-actions github-actions bot added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Mar 19, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3785 (edd9f4c) into develop (805ca0d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3785      +/-   ##
===========================================
- Coverage    10.78%   10.76%   -0.02%     
===========================================
  Files          269      270       +1     
  Lines        13403    13425      +22     
===========================================
  Hits          1445     1445              
- Misses       11958    11980      +22
Impacted Files Coverage Δ
...p/lib/pages/scan/smooth_barcode_scanner_mlkit.dart 0.00% <0.00%> (ø)
...p/lib/pages/scan/smooth_barcode_scanner_visor.dart 0.00% <0.00%> (ø)
...p/lib/pages/scan/smooth_barcode_scanner_zxing.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

M123-dev
M123-dev approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @monsieurtanuki some conflicts though 😿

@monsieurtanuki monsieurtanuki mentioned this pull request Mar 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees

@monsieurtanuki monsieurtanuki

Labels
PR: needs rebase 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bring back the old scan visor
3 participants
@monsieurtanuki @codecov-commenter @M123-dev