feat: 3772 - access to nutrion photo from nutrition page #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New file: * `product_image_unswipeable_view.dart`: Display of the photo of a product image field. Impacted files: * `nutrition_page_loaded.dart`: added a "go to picture" button * `product_image_swipeable_view.dart`: minor refactoring
Impacted file: * `product_image_unswipeable_view.dart`: now as a stateless widget.
teolemon
reviewed
Apr 6, 2023
Codecov Report
@@ Coverage Diff @@
## develop #3851 +/- ##
===========================================
- Coverage 10.77% 10.75% -0.02%
===========================================
Files 269 270 +1
Lines 13420 13441 +21
===========================================
Hits 1446 1446
- Misses 11974 11995 +21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
teolemon
approved these changes
Apr 6, 2023
|
Thank you @teolemon for your review! I assumed it was less confusing to go to only the nutrition picture on a "go to nutrition picture" button. Don't hesitate to create a new issue if you really prefer to go to swipeable pictures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New file:
product_image_unswipeable_view.dart: Display of the photo of a product image field.Impacted files:
nutrition_page_loaded.dart: added a "go to picture" buttonproduct_image_swipeable_view.dart: minor refactoringWhat
Screenshot
Fixes bug(s)