Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Shared common scanner #3883

Merged
merged 10 commits into from
Apr 18, 2023
Merged

chore: Shared common scanner #3883

merged 10 commits into from
Apr 18, 2023

Conversation

M123-dev
Copy link
Member

What

We had to get to the old state of the continuous delivery pipeline to allow to build a dedicated F-Droid build without non open source parts, namely ML Kit. To be able to build them I had to extract ZXing and ML Kit in theire own packages which we have as dependencies in smoothie. As they are only used in the entry point and in no other file the build still works when commenting out the not used scanner.

Automating this will be done in the next PR.

To be able to share the scanner around in the code, I created a new shared scanner interface.

  • Created the new packages
  • Moved the ML Kit and Zxing scanner to the new packages
  • Removed the camera awesome scanner
  • Removed the old scanner_type implementation
  • I have left the old currently not anymore in use scan visor untouched to not collide with feat: 3873 - less raw scan visor #3879
  • Some unrelated devcontainer.json changes. I worked in a GitHub code space on a public computer, interesting experience.

Part of

@M123-dev M123-dev requested a review from a team as a code owner April 17, 2023 19:23
@github-actions github-actions bot added 📈 Analytics We use Sentry and Matomo, with an opt-in system dependencies 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… 🧪 Tests 🤳 ZXing labels Apr 17, 2023
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @M123-dev, looks good to me!
I have minor comments; feel free to ignore them.
And let's go to the next step!

packages/scanner/ml_kit/lib/src/scanner_ml_kit.dart Outdated Show resolved Hide resolved
packages/scanner/ml_kit/lib/src/scanner_ml_kit.dart Outdated Show resolved Hide resolved
packages/scanner/ml_kit/lib/src/scanner_ml_kit.dart Outdated Show resolved Hide resolved
packages/scanner/ml_kit/test/scanner_zxing_test.dart Outdated Show resolved Hide resolved
packages/scanner/zxing/lib/src/scanner_zxing.dart Outdated Show resolved Hide resolved
@github-actions github-actions bot added 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🥫 Product page User lists labels Apr 18, 2023
@M123-dev
Copy link
Member Author

M123-dev commented Apr 18, 2023

Thanks for your review @monsieurtanuki, good things you mentioned. I've applied your suggestions :D

@M123-dev M123-dev merged commit f7e42c7 into develop Apr 18, 2023
@M123-dev M123-dev deleted the shared_common_scanner branch April 18, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Analytics We use Sentry and Matomo, with an opt-in system dependencies 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🥫 Product page 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… 🧪 Tests User lists 🤳 ZXing
Development

Successfully merging this pull request may close these issues.

2 participants