Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use our fork of mobile_scanner #4133

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 12, 2023

Hi everyone,

I've just forked mobile_scanner and I've not added any commit (yet).
By just doing this change, it will fix the issue we have on iOS, where iPhones with multiple cameras use the wrong scale by default.

So basically it will fix #3935

@g123k g123k self-assigned this Jun 12, 2023
@g123k g123k requested a review from a team as a code owner June 12, 2023 20:11
@codecov-commenter
Copy link

Codecov Report

Merging #4133 (f19530f) into develop (abab934) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4133      +/-   ##
===========================================
- Coverage    10.88%   10.87%   -0.01%     
===========================================
  Files          273      273              
  Lines        13568    13580      +12     
===========================================
  Hits          1477     1477              
- Misses       12091    12103      +12     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon teolemon merged commit 90e514f into openfoodfacts:develop Jun 12, 2023
@g123k g123k deleted the camera_ios_fix branch December 30, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The iPhone version should not use the wide angle (0,5x) back camera by default
3 participants