Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed buttons not having equal heights #4234

Closed
wants to merge 5 commits into from
Closed

fix: Fixed buttons not having equal heights #4234

wants to merge 5 commits into from

Conversation

hsradA23
Copy link
Contributor

What

  • Used IntrinsicHeight to fix unequal heights of buttons on small screen devices.
  • Added a container with margin to add empty space between the button rows.

Screenshot

image

Fixes bug(s)

  • Fixes: Unequal Heights of buttons on products image viewer page while on small screen devices.

Part of

@hsradA23 hsradA23 requested a review from a team as a code owner June 25, 2023 16:31
@g123k
Copy link
Collaborator

g123k commented Jun 25, 2023

The issue is also for the ingredients screen @hsradA23

@g123k g123k linked an issue Jun 25, 2023 that may be closed by this pull request
On small devices, some buttons don't have the same height #4228
Closed
@hsradA23
Copy link
Contributor Author

@g123k Can you give a screenshot of the ingredients screen, I have not been able to find the issue with these two ingredient screens:
image
image

@g123k
Copy link
Collaborator

g123k commented Jun 26, 2023

You're on the wrong screen, it's the ingredients editor, not viewer.

https://user-images.githubusercontent.com/246838/248502679-13261cb9-5753-4151-8da3-1c7e5790d2cc.png

g123k
g123k requested changes Jul 12, 2023
View reviewed changes
packages/smooth_app/lib/pages/product/edit_ocr_page.dart Outdated
Expanded(
child: Padding(
padding: const EdgeInsets.symmetric(
horizontal: SMALL_SPACE),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comma here to have a better formatted code, please?

packages/smooth_app/lib/pages/product/edit_ocr_page.dart Outdated
Expanded(
child: Padding(
padding: const EdgeInsets.symmetric(
horizontal: SMALL_SPACE),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same here please

packages/smooth_app/lib/pages/product/product_image_viewer.dart Outdated
Expanded(
child: Padding(
padding:
const EdgeInsets.symmetric(horizontal: SMALL_SPACE),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

packages/smooth_app/lib/pages/product/product_image_viewer.dart Outdated
Expanded(
child: Padding(
padding:
const EdgeInsets.symmetric(horizontal: SMALL_SPACE),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

packages/smooth_app/lib/pages/product/product_image_viewer.dart Outdated
language: widget.language,
isLoggedInMandatory: true,
Container(
margin: EdgeInsets.only(bottom: SMALL_SPACE),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a const before (the reason why the test fails)

packages/smooth_app/lib/pages/product/product_image_viewer.dart Outdated
imageField: widget.imageField,
language: widget.language,
isLoggedInMandatory: true,
Container(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you only use a Container, could you switch to a Padding one instead, please?

@teolemon
Copy link
Member

teolemon commented Aug 3, 2023

@hsradA23 are you still working on this ? if not, I will close the PR.

@teolemon teolemon closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g123k g123k g123k requested changes

Assignees

@hsradA23 hsradA23

Labels
buttons PR: needs rebase 🥫 Product page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On small devices, some buttons don't have the same height
3 participants
@hsradA23 @g123k @teolemon