ci: Add an action to upload APKs to Waldo #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4272 +/- ##
========================================
Coverage 10.87% 10.87%
========================================
Files 285 285
Lines 14170 14170
========================================
Hits 1541 1541
Misses 12629 12629 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
g123k
changed the title
M123-dev
reviewed
Jul 11, 2023
| with: | ||
| #channel: stable | ||
| cache: true | ||
| flutter-version: ${{ steps.flutter-version.outputs.FLUTTER_VERSION }} |
There was a problem hiding this comment.
You forgot to include the step which outputs the flutter version we want
There was a problem hiding this comment.
Ooops you're right, that's a bad copy/paste.
That should now be OK (line 28)
M123-dev
approved these changes
Jul 14, 2023
|
Thank you @M123-dev, let's try to merge it |
g123k
changed the title
|
You can test this PR on: Android |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is now really to upload APKs (IPA will come once we are confident this one works well).
It will only be with PRs in a first time, and also we can't have a direct link to the website to test, as the Waldo session doesn't provide what's necessary yet (a bug is opened on their side)