Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Better support error when saving the picture locally #4305

Merged
merged 5 commits into from
Jul 17, 2023
Merged

feat: Better support error when saving the picture locally #4305

merged 5 commits into from
Jul 17, 2023

Commits on Jul 17, 2023

  1. In the case where the user is stuck with the message "Saving a local … 

    …version…", we will now send the error to the server
    @g123k
    g123k committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    35fddbe View commit details
    Browse the repository at this point in the history

  2. Instead a cryptic message, explain to the user there's an issue with … 

    …the image processing
    @g123k
    g123k committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    8f7a0b0 View commit details
    Browse the repository at this point in the history

  3. Rebase the code to let the test pass

    @g123k
    g123k committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    8943f15 View commit details
    Browse the repository at this point in the history

  4. Revert the fact that _getCroppedImageFile can be nullable

    @g123k
    g123k committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    fdc435c View commit details
    Browse the repository at this point in the history

  5. Add a Future return to _showErrorDialog

    @g123k
    g123k committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6444246 View commit details
    Browse the repository at this point in the history