Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Settings now use Modal Sheets 🤩 #4307

Merged
merged 4 commits into from
Jul 22, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 14, 2023

Hi everyone!

I found the preferences too stressing, that's why this PR brings a few changes:

  • Generally speaking, there are more margins on the main page
  • My efforts were mainly on the App Settings, where I have tried to unify the settings
  • All Dropdowns now use a custom Widget that I developed far ago, but that wasn't used anymore
  • The new dropdowns use a Modal Sheet to select a value
  • Basically, there is no way to have a draggable Modal Sheet directly working on Flutter, hence some ModalRoute & co, that will be reusable for lists for example.

As always, a video: PrefsRevamped.webm

And a few screenshots, just in case:
Screenshot_1689356888
Screenshot_1689356890
Screenshot_1689356893
Screenshot_1689356900

@g123k g123k self-assigned this Jul 14, 2023
@g123k g123k requested a review from a team as a code owner July 14, 2023 17:50
@github-actions github-actions bot added 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🌐 l10n 🖼️ Photos - Cropping 🧪 Tests goldens and removed ⚙️ Settings labels Jul 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4307 (281b825) into develop (1cd22a6) will decrease coverage by 0.07%.
The diff coverage is 2.33%.

@@             Coverage Diff             @@
##           develop    #4307      +/-   ##
===========================================
- Coverage    10.80%   10.73%   -0.07%     
===========================================
  Files          287      289       +2     
  Lines        14202    14349     +147     
===========================================
+ Hits          1534     1541       +7     
- Misses       12668    12808     +140     
Impacted Files Coverage Δ
...generic_lib/bottom_sheets/smooth_bottom_sheet.dart 0.00% <0.00%> (ø)
...b/bottom_sheets/smooth_draggable_bottom_sheet.dart 0.00% <0.00%> (ø)
...om_sheets/smooth_draggable_bottom_sheet_route.dart 0.00% <0.00%> (ø)
...app/lib/generic_lib/widgets/language_selector.dart 0.00% <0.00%> (ø)
packages/smooth_app/lib/pages/image_crop_page.dart 1.00% <ø> (ø)
...oth_app/lib/pages/onboarding/country_selector.dart 0.81% <0.00%> (-0.02%) ⬇️
...ib/pages/preferences/user_preferences_widgets.dart 8.16% <0.00%> (-4.74%) ⬇️
...b/pages/preferences/user_preferences_settings.dart 8.49% <4.10%> (+2.18%) ⬆️
...ib/pages/preferences/user_preferences_account.dart 62.70% <100.00%> (+0.40%) ⬆️
.../pages/preferences/user_preferences_list_tile.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of general purpose code which makes sense when moving more and more to bottom sheets, looks great just a conflict

@github-actions
Copy link
Contributor

@g123k
Copy link
Collaborator Author

g123k commented Jul 21, 2023

That should be OK for the rebase now

@g123k g123k merged commit ef15cab into openfoodfacts:develop Jul 22, 2023
7 checks passed
@g123k g123k deleted the prefs_with_modal_sheets branch July 22, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goldens 🌐 l10n MacOS 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🖼️ Photos - Cropping 🧪 Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants