-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Settings now use Modal Sheets 🤩 #4307
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4307 +/- ##
===========================================
- Coverage 10.80% 10.73% -0.07%
===========================================
Files 287 289 +2
Lines 14202 14349 +147
===========================================
+ Hits 1534 1541 +7
- Misses 12668 12808 +140
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of general purpose code which makes sense when moving more and more to bottom sheets, looks great just a conflict
…odal sheet + some UI improvements in the settings globally
ca7a78b
to
69e17d7
Compare
You can test this PR on: https://app.waldo.com/applications/app-19d476740ba1bb36/sessions |
That should be OK for the rebase now |
Hi everyone!
I found the preferences too stressing, that's why this PR brings a few changes:
Widget
that I developed far ago, but that wasn't used anymoreModalRoute
& co, that will be reusable for lists for example.As always, a video: PrefsRevamped.webm
And a few screenshots, just in case: