Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: A haptic feedback for the close button #4319

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 15, 2023

Hi everyone,

A small addition to bring a small vibration for the close button in a card
(I know you think that's nothing, but try the app with/without and you will understand)

@g123k g123k requested a review from a team as a code owner July 15, 2023 23:34
@codecov-commenter
Copy link

Codecov Report

Merging #4319 (cfc7573) into develop (00f42ae) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4319      +/-   ##
===========================================
- Coverage    10.80%   10.79%   -0.01%     
===========================================
  Files          287      287              
  Lines        14203    14205       +2     
===========================================
  Hits          1534     1534              
- Misses       12669    12671       +2     
Impacted Files Coverage Δ
.../cards/product_cards/smooth_product_base_card.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you with that

@g123k
Copy link
Collaborator Author

g123k commented Jul 16, 2023

I trust you with that

Thanks for your trust Marvin 😆

@g123k g123k merged commit b060d44 into openfoodfacts:develop Jul 16, 2023
7 checks passed
@g123k g123k deleted the haptic_close_button branch July 16, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants