Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Permissions page with "a well balanced" style #4341

Merged

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 19, 2023

Hi everyone,

The consent page uses a "well-balanced" style with a higher line height.
This PR does the same for the Permission's page.

Before:
Screenshot_1689780593

After:
Screenshot_1689780503

It's part of #4230

@g123k g123k added the 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… label Jul 19, 2023
@g123k g123k requested a review from a team as a code owner July 19, 2023 15:34
@g123k g123k self-assigned this Jul 19, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4341 (0506821) into develop (5b376d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4341   +/-   ##
========================================
  Coverage    10.54%   10.54%           
========================================
  Files          290      290           
  Lines        14294    14294           
========================================
  Hits          1507     1507           
  Misses       12787    12787           
Impacted Files Coverage Δ
...oth_app/lib/pages/onboarding/permissions_page.dart 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

@M123-dev M123-dev merged commit b9c6be7 into openfoodfacts:develop Jul 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants