Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use Plus Jakarta Sans as the default font #4361

Closed
wants to merge 3 commits into from

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 22, 2023

Hi everyone,

In the design, Plus Jarkarta Sans is the font used by default.
This PR switches all the app to it.

Screenshot_1690038288

@g123k g123k requested a review from a team as a code owner July 22, 2023 15:05
@g123k g123k self-assigned this Jul 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2023

Codecov Report

Merging #4361 (da44116) into develop (899cea6) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #4361      +/-   ##
===========================================
- Coverage    10.45%   10.37%   -0.08%     
===========================================
  Files          291      293       +2     
  Lines        14416    14641     +225     
===========================================
+ Hits          1507     1519      +12     
- Misses       12909    13122     +213     
Impacted Files Coverage Δ
packages/smooth_app/lib/main.dart 13.11% <ø> (ø)
packages/smooth_app/lib/themes/smooth_theme.dart 77.31% <100.00%> (+1.23%) ⬆️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

@teolemon
Copy link
Member

We reverted in the past because it doesn't work for all locales

@g123k
Copy link
Collaborator Author

g123k commented Jul 22, 2023

Here is a list of unsupported langagues:

 // Adyghe, Avaric,Azerbaijani (Cyrillic),Bosnian (Cyrillic),Bulgarian
    //Chechen,Chuvash,Dargwa,Erzya,Evenki,Gagauz, Cyrillic,Interlingua,
    // Kabardian,Karachay-Balkar,Khakas, Komi, Komi-Permyak, Kumyk, Kurdish
    //Lak,Lezghian,Macedonian,Mari,Modern Greek,Moksha,Mongolian,Nanai,Nenets,
    // Ossetic,Romanian, Cyrillic,Russian,Russian Buriat,Rusyn,Sakha,Shor,
    // Southern Altai,Udmurt,Ukrainian,Western Mari

We should tell to revert to Roboto for them

@monsieurtanuki
Copy link
Contributor

Here is a list of unsupported languages:

@g123k Keep in mind the maintainability. If reaaaaally you don't like the default font, please find a different font that works for all languages. If not, I would suggest you to close this PR.

@g123k
Copy link
Collaborator Author

g123k commented Jul 23, 2023

Here is a list of unsupported languages:

@g123k Keep in mind the maintainability. If reaaaaally you don't like the default font, please find a different font that works for all languages. If not, I would suggest you to close this PR.

Actually, even Roboto doesn't support all languages.
Jakarta supports languages that Roboto doesn't and vice-versa.

@teolemon
Copy link
Member

teolemon commented Aug 3, 2023

@monsieurtanuki
Copy link
Contributor

off-dart currently supports 185 languages.
Both Roboto and Djakarta support more languages, and Public Sans supports less languages than Roboto.
To have a clear idea we need to check languages one by one, in order to filter to languages we do need.

@g123k g123k mentioned this pull request Aug 14, 2023
@g123k
Copy link
Collaborator Author

g123k commented Aug 14, 2023

I close this PR, as a real plan B is to use a real universal font.
Even if we use Roboto, it doesn't implement all the languages we need

@g123k g123k closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants