-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use Plus Jakarta Sans as the default font #4361
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4361 +/- ##
===========================================
- Coverage 10.45% 10.37% -0.08%
===========================================
Files 291 293 +2
Lines 14416 14641 +225
===========================================
+ Hits 1507 1519 +12
- Misses 12909 13122 +213
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
You can test this PR on: https://app.waldo.com/applications/app-19d476740ba1bb36/sessions |
We reverted in the past because it doesn't work for all locales |
Here is a list of unsupported langagues:
We should tell to revert to Roboto for them |
@g123k Keep in mind the maintainability. If reaaaaally you don't like the default font, please find a different font that works for all languages. If not, I would suggest you to close this PR. |
Actually, even Roboto doesn't support all languages. |
|
off-dart currently supports 185 languages. |
I close this PR, as a real plan B is to use a real universal font. |
Hi everyone,
In the design, Plus Jarkarta Sans is the font used by default.
This PR switches all the app to it.