Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nutrition facts array in a bottom sheet #4362

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 22, 2023

Hi everyone,

As suggested by @teolemon in #4278 (comment), here are nutrition facts in a modal sheet:

Screenshot 2023-07-22 at 17 43 12 Screenshot 2023-07-22 at 17 43 18

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2023

Codecov Report

Merging #4362 (4bee468) into develop (ef15cab) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4362      +/-   ##
===========================================
- Coverage    10.34%   10.34%   -0.01%     
===========================================
  Files          293      293              
  Lines        14636    14640       +4     
===========================================
  Hits          1514     1514              
- Misses       13122    13126       +4     
Impacted Files Coverage Δ
...generic_lib/bottom_sheets/smooth_bottom_sheet.dart 0.00% <ø> (ø)
...ooth_app/lib/pages/product/portion_calculator.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

@teolemon
Copy link
Member

@g123k conflicts to solve

@g123k
Copy link
Collaborator Author

g123k commented Jul 24, 2023

@g123k conflicts to solve

That should be OK now ☺️

@teolemon teolemon merged commit c2c904d into openfoodfacts:develop Jul 24, 2023
7 checks passed
@g123k g123k deleted the nutrition_facts_bottom_sheet branch July 28, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants