Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Amoled color picker not working on non-english languages #4386

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 28, 2023

Hi everyone,

On non-english languages, the color picker doesn't work.
A single line fix for #4367

Screenshot 2023-07-28 at 09 06 06

@g123k g123k requested a review from a team as a code owner July 28, 2023 07:08
@g123k g123k self-assigned this Jul 28, 2023
@g123k g123k linked an issue Jul 28, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #4386 (dd3d43f) into develop (f9b7b9d) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #4386   +/-   ##
========================================
  Coverage    10.29%   10.29%           
========================================
  Files          293      293           
  Lines        14752    14752           
========================================
  Hits          1519     1519           
  Misses       13233    13233           
Files Changed Coverage Δ
...b/pages/preferences/user_preferences_settings.dart 8.49% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

You can test this PR on: Android

@teolemon teolemon merged commit 1a8e7cf into openfoodfacts:develop Jul 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color picker for AMOLED theme is broken on non-English languages
3 participants