Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix for ScrollController has no ScrollPosition #4387

Merged

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 28, 2023

Hi everyone,

On some screens (settings & product edition more particularly), we have such errors:

The Scrollbar's ScrollController has no ScrollPosition attached.
A Scrollbar cannot be painted without a ScrollPosition.
The Scrollbar attempted to use the PrimaryScrollController. This ScrollController should be associated with the ScrollView that the Scrollbar is being applied to.When ScrollView.scrollDirection is Axis.vertical on mobile platforms will automatically use the PrimaryScrollController if the user has not provided a ScrollController. To use the PrimaryScrollController explicitly, set ScrollView.primary to true for the Scrollable widget.

The issue is only to ensure to give the same controller both to the Scrollbar and the ScrollView-like Widget.

@g123k g123k added the 🐛 bug Something isn't working label Jul 28, 2023
@g123k g123k requested a review from a team as a code owner July 28, 2023 07:20
@g123k g123k self-assigned this Jul 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4387 (4898cb2) into develop (f9b7b9d) will increase coverage by 0.02%.
The diff coverage is 8.69%.

@@             Coverage Diff             @@
##           develop    #4387      +/-   ##
===========================================
+ Coverage    10.29%   10.32%   +0.02%     
===========================================
  Files          293      293              
  Lines        14752    14756       +4     
===========================================
+ Hits          1519     1523       +4     
  Misses       13233    13233              
Files Changed Coverage Δ
...mooth_app/lib/pages/product/edit_product_page.dart 0.51% <0.00%> (ø)
...p/lib/pages/preferences/user_preferences_page.dart 93.90% <100.00%> (+0.31%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

You can test this PR on: Android

@teolemon teolemon merged commit 05850f3 into openfoodfacts:develop Jul 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🥫 Product page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants