Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ensure native settings / rate app / share app entries look the same #4388

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 28, 2023

Hi everyone,

In the app settings, items to open native settings / rate the app / share the app weren't visualy consistent.

Screenshot 2023-07-28 at 09 55 01

Will fix #4359

@g123k g123k requested a review from a team as a code owner July 28, 2023 08:01
@codecov-commenter
Copy link

Codecov Report

Merging #4388 (d4f655d) into develop (f9b7b9d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4388      +/-   ##
===========================================
- Coverage    10.29%   10.29%   -0.01%     
===========================================
  Files          293      293              
  Lines        14752    14753       +1     
===========================================
  Hits          1519     1519              
- Misses       13233    13234       +1     
Files Changed Coverage Δ
...b/pages/preferences/user_preferences_settings.dart 8.66% <0.00%> (+0.16%) ⬆️
...ib/pages/preferences/user_preferences_widgets.dart 8.17% <0.00%> (-0.33%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

You can test this PR on: Android

@teolemon teolemon merged commit 7f81b3d into openfoodfacts:develop Jul 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App settings: some titles don't have the same font size
3 participants