Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Filterable text: ensure to remove accents when comparing #4394

Merged

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 28, 2023

Hi everyone,

While testing if #4389 was still OK once merged, I totally forgot to support accentuated characters.
For example: Français will be OK when spelled with Francais.

Screenshot 2023-07-29 at 01 29 21

@g123k g123k self-assigned this Jul 28, 2023
@g123k g123k requested a review from a team as a code owner July 28, 2023 23:32
@github-actions github-actions bot added 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… and removed ✏️ Editing - Nutrition input labels Jul 28, 2023
@g123k g123k changed the title Filterable text: ensure to remove accents when comparing fix; Filterable text: ensure to remove accents when comparing Jul 28, 2023
@g123k g123k changed the title fix; Filterable text: ensure to remove accents when comparing feat: Filterable text: ensure to remove accents when comparing Jul 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4394 (6edb869) into develop (a08a2f9) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4394      +/-   ##
===========================================
- Coverage    10.29%   10.28%   -0.01%     
===========================================
  Files          293      293              
  Lines        14757    14763       +6     
===========================================
  Hits          1519     1519              
- Misses       13238    13244       +6     
Files Changed Coverage Δ
...app/lib/generic_lib/widgets/language_selector.dart 0.00% <0.00%> (ø)
...oth_app/lib/pages/onboarding/country_selector.dart 0.80% <0.00%> (-0.03%) ⬇️
packages/smooth_app/lib/widgets/smooth_text.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

You can test this PR on: Android

@teolemon teolemon merged commit ba7d988 into openfoodfacts:develop Jul 29, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
countries 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants