Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Setup image_picker for macOS #4397

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 29, 2023

Hi everyone,

It seems that the configuration of the image_picker was not fully implemented, as the macOS is missing.
Windows and Linux don't require a specific configuration according to the doc.

It will fix #4396 (= the file picker was never showing)

Screenshot 2023-07-29 at 10 28 25

@g123k g123k self-assigned this Jul 29, 2023
@g123k g123k requested a review from a team as a code owner July 29, 2023 08:31
@codecov-commenter
Copy link

Codecov Report

Merging #4397 (c64220f) into develop (a08a2f9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4397   +/-   ##
========================================
  Coverage    10.29%   10.29%           
========================================
  Files          293      293           
  Lines        14757    14757           
========================================
  Hits          1519     1519           
  Misses       13238    13238           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

You can test this PR on: Android

@g123k g123k changed the title feat: Setup image_picker for iOS feat: Setup image_picker for macOS Jul 29, 2023
@teolemon teolemon merged commit 8231db0 into openfoodfacts:develop Jul 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS only] When a device doesn't have a camera, we can't upload an image (even from the gallery)
3 participants