Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: User lists: bring "Share" / "View on web" / "Clear" actions to the Modal sheet #4400

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 29, 2023

Hi everyone,

The actions available in the user lists tab are also available in the Modal Sheet, that is to say:

  • Sharing a list
  • Viewing a list on the web
  • Clearing the content (if not empty)

Unfortunately, I can't bring the Rename feature, as it's considered as a new list.
I've also fixed a potential issue, when you delete a list in the Modal Sheet and you were on the screen with this list -> in that case it will fall back to the history.

I've also tweaked a little bit the Modal sheet to ensure we have a bold title.

Everything is visible in the video:

RocketSim_Recording_iPhone_14_Pro_2023-07-29_21.27.33.mp4

It will fix #4390

@g123k g123k requested a review from a team as a code owner July 29, 2023 19:35
@g123k g123k self-assigned this Jul 29, 2023
@g123k g123k changed the title feat: User lists: bring Share / View on web / Clear actions to the Modal sheet feat: User lists: bring "Share" / "View on web" / "Clear" actions to the Modal sheet Jul 29, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4400 (767dd77) into develop (a08a2f9) will decrease coverage by 0.15%.
Report is 13 commits behind head on develop.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4400      +/-   ##
===========================================
- Coverage    10.29%   10.14%   -0.15%     
===========================================
  Files          293      295       +2     
  Lines        14757    15088     +331     
===========================================
+ Hits          1519     1531      +12     
- Misses       13238    13557     +319     
Files Changed Coverage Δ
...kages/smooth_app/lib/data_models/product_list.dart 0.00% <ø> (ø)
...ages/smooth_app/lib/database/dao_product_list.dart 0.00% <0.00%> (ø)
...generic_lib/bottom_sheets/smooth_bottom_sheet.dart 0.00% <0.00%> (ø)
...b/bottom_sheets/smooth_draggable_bottom_sheet.dart 0.00% <0.00%> (ø)
...om_sheets/smooth_draggable_bottom_sheet_route.dart 0.00% <ø> (ø)
...es/smooth_app/lib/pages/all_product_list_page.dart 0.00% <0.00%> (ø)
...p/lib/pages/product/common/product_list_modal.dart 0.00% <0.00%> (ø)
...pages/product/common/product_list_popup_items.dart 0.00% <0.00%> (ø)

... and 32 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

You can test this PR on: Android

@teolemon teolemon merged commit 3f2b7a7 into openfoodfacts:develop Jul 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User lists: add the same features in Modal Sheet as on the screen
3 participants